Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a coercing function of boolean #3

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Conversation

totakke
Copy link
Member

@totakke totakke commented Jul 28, 2017

Adds as-boolean. This function is different from Boolean/parseBoolean in that it

  • also supports "Yes" and "No"
  • returns nil if an illegal string is passed (Boolean/parseBoolean returns false in that case).

I feel this behavior is strict and useful.

@codecov
Copy link

codecov bot commented Jul 28, 2017

Codecov Report

Merging #3 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #3     +/-   ##
=========================================
+ Coverage   90.51%   90.71%   +0.2%     
=========================================
  Files           4        4             
  Lines         137      140      +3     
  Branches        3        3             
=========================================
+ Hits          124      127      +3     
  Misses         10       10             
  Partials        3        3
Impacted Files Coverage Δ
src/cljc/proton/core.cljc 91.04% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8923193...74b31cb. Read the comment docs.

@federkasten federkasten merged commit 50c4006 into master Jul 28, 2017
@federkasten
Copy link
Member

Thank you :)

@totakke totakke deleted the feature/boolean-coercing branch July 28, 2017 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants