Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SR_CACHING capability for many SR types #24

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Remove SR_CACHING capability for many SR types #24

merged 1 commit into from
Jun 23, 2022

Conversation

Wescoeur
Copy link
Member

@Wescoeur Wescoeur commented Jun 1, 2022

SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of _setup_cache in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon ronan.abhamon@vates.fr

@Wescoeur Wescoeur force-pushed the 2.30.6-8.2-remove-intellicache-capability branch from d76205c to 637a287 Compare June 1, 2022 13:53
@MatiasVara
Copy link

From the commit message, I do not understand very well the purpose of this commit. Why are you removing SR_CACHING capability for many SR types?

@Wescoeur Wescoeur force-pushed the 2.30.6-8.2-remove-intellicache-capability branch from 5352701 to 79e0664 Compare June 14, 2022 09:03
@Wescoeur
Copy link
Member Author

@MatiasVara SR_CACHING offers the capacity to use IntelliCache, but this feature is only available using NFS SR.

@Wescoeur Wescoeur changed the title [WIP] Remove SR_CACHING capability for many SR types Remove SR_CACHING capability for many SR types Jun 14, 2022
@Wescoeur Wescoeur force-pushed the 2.30.6-8.2-remove-intellicache-capability branch from 79e0664 to 637a287 Compare June 14, 2022 09:40
stormi
stormi reviewed Jun 14, 2022
View reviewed changes
drivers/SMBSR.py Outdated Show resolved Hide resolved
@MatiasVara
Copy link

I understand so you are removing the SR_CACHING capability from those SRs that do not support it and lets it in NFS SR. My suggestion would be a commit message like the following:

Remove SR_CACHING capability from those SRs that do not support it

This commit removes the SR_CACHING capability from those SRs that do not support it and
lets it in NFS SR to leverage IntelliCache.

@Wescoeur Wescoeur force-pushed the 2.30.6-8.2-remove-intellicache-capability branch from 637a287 to 0e85c11 Compare June 15, 2022 15:28
@Wescoeur Wescoeur requested a review from stormi June 15, 2022 15:29
@Wescoeur Wescoeur changed the base branch from 2.30.6-8.2 to 2.30.7-8.2 June 15, 2022 15:30
@Wescoeur
Remove SR_CACHING capability for many SR types
8d83f5d 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
@Wescoeur Wescoeur force-pushed the 2.30.6-8.2-remove-intellicache-capability branch from 0e85c11 to 8d83f5d Compare June 15, 2022 15:30
@Wescoeur Wescoeur merged commit 213cf8a into 2.30.7-8.2 Jun 23, 2022
@Wescoeur Wescoeur deleted the 2.30.6-8.2-remove-intellicache-capability branch June 23, 2022 08:37
Wescoeur added a commit that referenced this pull request Jun 23, 2022
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
cda03ac 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Jul 6, 2022
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
d027cec 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Jul 7, 2022
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
b04cc23 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Jul 7, 2022
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
cd02584 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
andrey-podko pushed a commit to andrey-podko/sm that referenced this pull request Aug 16, 2022
@Wescoeur
Remove SR_CACHING capability for many SR types (xcp-ng#24)
c46c3c6 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.
Wescoeur added a commit that referenced this pull request Sep 1, 2022
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
49f1ec3 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Dec 8, 2022
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
f6e1ffa 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Dec 8, 2022
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
3b6f579 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
stormi pushed a commit that referenced this pull request Dec 14, 2022
@Wescoeur @stormi
Remove SR_CACHING capability for many SR types (#24)
fdb8a18 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
stormi pushed a commit that referenced this pull request Dec 15, 2022
@Wescoeur @stormi
Remove SR_CACHING capability for many SR types (#24)
ebcdc33 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Mar 6, 2023
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
1f9bc2c 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Mar 6, 2023
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
f0c45bf 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
ydirson pushed a commit that referenced this pull request Mar 27, 2023
@Wescoeur @ydirson
Remove SR_CACHING capability for many SR types (#24)
596e589 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Apr 17, 2023
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
945a52b 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
ydirson pushed a commit that referenced this pull request Apr 20, 2023
@Wescoeur @ydirson
Remove SR_CACHING capability for many SR types (#24)
4aac153 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Apr 25, 2023
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
32be9cf 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Jul 31, 2023
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
bf751cb 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Aug 1, 2023
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
95f6b48 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Sep 18, 2023
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
155b72d 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Sep 18, 2023
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
1ee59de 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Sep 18, 2023
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
910df4d 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Oct 13, 2023
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
bdb7ced 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Dec 11, 2023
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
0159bc5 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Jan 23, 2024
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
f3a45ac 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Feb 6, 2024
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
864d51d 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Apr 10, 2024
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
e72a1e3 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Apr 11, 2024
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
4cbbd73 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Jun 12, 2024
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
bf7577f 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Jun 12, 2024
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
658d391 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Jun 24, 2024
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
a6ba784 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Aug 12, 2024
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
38c52ed 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Aug 12, 2024
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
fdddd2b 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Aug 13, 2024
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
a98657a 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Aug 13, 2024
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
e099766 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
benjamreis pushed a commit that referenced this pull request Aug 13, 2024
@Wescoeur @benjamreis
Remove SR_CACHING capability for many SR types (#24)
3c420bc 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Wescoeur added a commit that referenced this pull request Oct 3, 2024
@Wescoeur
Remove SR_CACHING capability for many SR types (#24)
9d45a0e 
SR_CACHING offers the capacity to use IntelliCache, but this
feature is only available using NFS SR.

For more details, the implementation of `_setup_cache` in blktap2.py
uses only an instance of NFSFileVDI for the shared target.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormi stormi stormi approved these changes

@MatiasVara MatiasVara Awaiting requested review from MatiasVara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wescoeur @MatiasVara @stormi