Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The xcube server STAC API now publishes all fields available via the /datasets endpoint. #1045

Conversation

konstntokas
Copy link
Contributor

@konstntokas konstntokas commented Jul 17, 2024

Closes #925

Furthermore, all fields of each dataset published via the /dataset endpoint have been been added to the xcube server STAC API.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@konstntokas konstntokas changed the title ready for PR The xcube server STAC API now publishes all fields available via the /datasets endpoint. Jul 17, 2024
@konstntokas konstntokas requested a review from forman July 17, 2024 07:46
Copy link
Member

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually approved, but please

  • rename bboxs occurences into bboxes. You can merge after doing so.
  • prepare another PR where we also include more missing dataset metadata, such as new group_title, and tags, please see aoutput of the /datasets?details=1 endpoint.

@@ -504,6 +503,37 @@ def _get_datasets_collection(
}


def _get_bboxs(ds_ctx: DatasetsContext):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def _get_bboxs(ds_ctx: DatasetsContext):
def _get_bboxes(ds_ctx: DatasetsContext):

@@ -504,6 +503,37 @@ def _get_datasets_collection(
}


def _get_bboxs(ds_ctx: DatasetsContext):
configs = ds_ctx.get_dataset_configs()
bboxs = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

boxes

@konstntokas konstntokas merged commit f30f886 into main Jul 17, 2024
3 checks passed
@konstntokas konstntokas deleted the konstntokas-935-migrate_dataset_attributes_from_datasets_to_stac branch July 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants