-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of Dask-Arrays in xcube.core.geom #672
Conversation
Codecov Report
@@ Coverage Diff @@
## master #672 +/- ##
==========================================
+ Coverage 92.33% 92.39% +0.06%
==========================================
Files 307 307
Lines 28844 28973 +129
==========================================
+ Hits 26632 26769 +137
+ Misses 2212 2204 -8
Continue to review full report at Codecov.
|
Looks good! Demo notebook works nicely, and I successfully ran a number of stress tests with larger data volumes. |
In this PR:
The functions
mask_dataset_by_geometry()
andrasterize_features()
of modulexcube.core.geom
have been reimplemented to generate lazy dask arrays. Both should now be applicable to datasets that have arbitrarily large spatial dimensions. The spatial chunk sizes to be used can be specified using keyword argumenttile_size
.Deprecated following functions of module
xcube.core.geom
:is_dataset_y_axis_inverted()
is no longer used;get_geometry_mask()
is no longer used;convert_geometry()
has been renamed tonormalize_geometry()
.Closes #593.
Closes #666.
Checklist:
New/modified features documented indocs/source/*
CHANGES.md