Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PartialRatio issue #80

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Fix PartialRatio issue #80

merged 2 commits into from
Apr 15, 2020

Conversation

burdoto
Copy link
Contributor

@burdoto burdoto commented Apr 15, 2020

Fixes #39

This Pull Requests uses @BobLd's fix suggestion to fix issue #39.
An additional Test case for Issues and Bugs has been created. This case finishes successfully with this change.

@xdrop
Copy link
Owner

xdrop commented Apr 15, 2020

Thanks! Will release this soon.

@xdrop xdrop merged commit 899e5a0 into xdrop:master Apr 15, 2020
@burdoto
Copy link
Contributor Author

burdoto commented Apr 15, 2020

Hey @xdrop, another thing: You still have the .travis.yml file in master branch, but Travis doesn't seem to be set up for this repositories master branch.

@xdrop
Copy link
Owner

xdrop commented Apr 15, 2020

Hey @xdrop, another thing: You still have the .travis.yml file in master branch, but Travis doesn't seem to be set up for this repositories master branch.

Looks like they dropped support for openjdk7

"Expected feature release number in range of 9 to 15, but got: 7"

Will need to probably switch to a higher version one, thanks

@burdoto
Copy link
Contributor Author

burdoto commented Apr 15, 2020

I remember this, it's just a matter of changing openjdk7 to openjdk9 or oraclejdk7 (or 8), if you define Java version 7 in your POM files.

Regarding #75; I've made a Trie implementation @ org.comroid:trie and I'm currently investigating whether its possible to use a Trie structure to support extreme String sizes. I'm using the 'develop' branch from before for this.

@maxbachmann maxbachmann mentioned this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partialRatio issue
2 participants