core: add CallableOpInterface and use in interpreter #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
- Coverage 88.62% 88.59% -0.03%
==========================================
Files 156 158 +2
Lines 22022 22083 +61
Branches 3307 3315 +8
==========================================
+ Hits 19516 19565 +49
- Misses 1975 1985 +10
- Partials 531 533 +2
☔ View full report in Codecov by Sentry. |
PapyChacal
approved these changes
Jun 20, 2023
Comment on lines
+336
to
+338
| if isinstance(op, str): | ||
| name = op | ||
| op = self.get_op_for_symbol(op) |
There was a problem hiding this comment.
I think it's a trap!
CallableOp is not SymbolOp. But I've always seen them used in pairs.. not sure what to do in the long run, but I would just restrict call_op to CallableOp here
There was a problem hiding this comment.
Seems like it should be ok, this function accepts ops that are not symbol ops
There was a problem hiding this comment.
Oh right, it's not the proper SymbolRefAttr fetching just yet.
I can leave with polishing later then 👍
webmiche
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the bare minimum in terms of functionality for now.