dialects: (affine) use maps in affine.for bounds, and add some helpers #1209
Conversation
superlopuh
requested review from
tobiasgrosser,
nazavode,
compor,
AntonLydike,
JosseVanDelm,
PapyChacal and
adutilleul
superlopuh
requested review from
webmiche,
math-fehr and
georgebisbas
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 88.66% 88.60% -0.06%
==========================================
Files 167 167
Lines 22873 22905 +32
Branches 3478 3483 +5
==========================================
+ Hits 20280 20296 +16
- Misses 2038 2054 +16
Partials 555 555
☔ View full report in Codecov by Sentry. |
xdsl/ir/affine/affine_map.py
Outdated
| @staticmethod | ||
| def from_constant(value: int) -> AffineMap: | ||
| return AffineMap(0, 0, [AffineExpr.constant(value)]) |
There was a problem hiding this comment.
Can we call this method constant_map instead?
There was a problem hiding this comment.
How about just constant?
There was a problem hiding this comment.
I prefer constant_map. It's also what mlir uses.
| @staticmethod | ||
| def empty() -> AffineMap: | ||
| return AffineMap(0, 0, []) | ||
|
|
There was a problem hiding this comment.
Can you make the empty method with dims = 0, syms = 0?
There was a problem hiding this comment.
you mean explicitly specifying the arguments?
There was a problem hiding this comment.
No, I meant the api. But it's fine, I can extend this later.
superlopuh
force-pushed
the
sasha/affine/maps
branch
from
1f3fc5f
to
8d74060
Compare
@Groverkss