ci: (ruff) Add rule UP034 #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingiler
requested review from
tobiasgrosser,
superlopuh,
compor,
AntonLydike and
adutilleul
kingiler
added
CI
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
=======================================
Coverage 90.02% 90.02%
=======================================
Files 214 214
Lines 26666 26666
Branches 3964 3964
=======================================
Hits 24007 24007
Misses 2026 2026
Partials 633 633
☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Aug 11, 2023
| @@ -2380,7 +2380,7 @@ def __init__( | |||
| @classmethod | |||
| def parse(cls, parser: Parser) -> AssemblySectionOp: | |||
| directive = parser.parse_str_literal() | |||
| attr_dict = parser.parse_optional_attr_dict_with_keyword(("directive")) | |||
| attr_dict = parser.parse_optional_attr_dict_with_keyword(("directive",)) | |||
There was a problem hiding this comment.
Yay for python strings being iterables of string 😅
adutilleul
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule is to avoid extraneous parentheses.
A bug was found when adding ruff rule UP034. The code intends to have a tuple of strings but a missing comma makes it becomes extraneous parentheses.