dialect,backend: Experimental CSL dialect and printer #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added return type printing to the CSL function printer
Unlike `func.call`, `csl.call` can only have one result.
Reusing the same logic as MemberCallOp
Operations to represent CSL tasks. All three task kinds are represented by the same op. Control tasks not yet supported.
Most of the functionality is shared with FuncOp printer. Tasks are immediately bound to their IDs when they are printed.
For now only local and data tasks are tested, because control tasks are not yet implemented.
Moved the shared parts of FuncOp and TaskOp into a common superclass.
Where the name of the op needs to be mentioned in an error message, use the `name` field instead.
Rather than `Data[EnumType]`.
Added `SpacedOpaqueSyntaxAttribute` as a base class.
Now printing the properties as well.
This module is nested within the top level builtin ModuleOp and is used to differentiate between the layout module and the program module. The same op is used for both, they are differentiated with the `kind` attribute.
This script takes the output of xdsl-opt using the csl printer and splits it into a layout program files.
Just a container for operations to delimit them from global operations.
Now `scf.for` with arguments and results work by using mutable variables.
This is a port of gemv-01-complete-program from https://github.com/Cerebras/csl-examples/ to MLIR.
Removed AttrSizedOperandSegments option from MemberCallOp and CallOp.
Verifying that `var_name` is set when `value` is set.
Fixed the printer after call and member_call were updated.
`sym_name` should be used for the name of the symbol, even if `var_name` is provided.
Added a filecheck test which utilises all features implemented so far.
AntonLydike
reviewed
May 15, 2024
| } | ||
| } | ||
|
|
||
| // CHECK-NEXT: param memcpy_params : comptime_struct; |
There was a problem hiding this comment.
I think this is missing the struct body, no?
There was a problem hiding this comment.
It's a param declaration with no default. It corresponds to this csl.param op.
AntonLydike
reviewed
May 15, 2024
| // CHECK-NEXT: comptime { | ||
| // CHECK-NEXT: @rpc(@get_data_task_id(LAUNCH)); | ||
| // CHECK-NEXT: } | ||
| // CHECK-NEXT: // >>>>>>>>>>>>>>>>>>>>><<<<<<<<<<<<<<<<<<<<< // |
There was a problem hiding this comment.
Ohh, so this is the "boundary" between layout and program module?
AntonLydike
pushed a commit
that referenced
this pull request
May 15, 2024
This PR is first in a series trying to split #2592 into more reviewable chunks. Adding basic CSL type representations to the dialect.
AntonLydike
pushed a commit
that referenced
this pull request
Jun 3, 2024
… builtins (#2684) This PR adds * Types + `csl.color` * Attributes + Boolean attribute + String attribute * Operations + `csl.param` + `csl.const_struct` + `csl.set_tile_code` + `csl.set_rectangle` + `csl.get_color` + `csl.rpc` It adds the last changes made in #2592, which can be closed when this is merged.
|
@dk949 is everything from this merged now? |
|
@AntonLydike All except the csl-file-adapter. Frankly, this was just a hack to get something compiling with cslc. Better suggestions for how to split the resulting CSL code into two files is welcome. |
|
What's the purpose of this PR? Is it to track ongoing work and unimplemented features in the csl dialect? |
It was used as a reference for early work on the CSL dialect. All features in here have been merged/substantially modified by other PRs. I think it can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An experimental implementation of the CSL dialect modeling the CSL language used by the Cerebras WSE based systems.
Also includes a backend generating the CSL language and a tool to split output of the backend into the files consumable by cslc.
Files will need to be moved to the experimental directory before merging
Currently implemented features:
Types
csl.ptrcsl.comptime_structcsl.colorcsl.stringcsl.typeAttributes
csl.module_kindcsl.task_kindcsl.ptr_kindcsl.ptr_constOps
csl.modulecsl.layoutcsl.paramcsl.import_modulecsl.member_accesscsl.member_callcsl.addressofcsl.funccsl.taskcsl.callcsl.returncsl.exportcsl.set_rectanglecsl.set_tile_codecsl.rpccsl.get_colorcsl.const_structcsl.const_strcsl.const_typeNon-CSL ops supported by the printer
arith.Addfarith.Addiarith.Constantarith.ExtFOparith.ExtSIOparith.ExtUIOparith.FPToSIOparith.IndexCastOparith.Mulfarith.Muliarith.SIToFPOparith.TruncFOparith.TruncIOpmemref.GetGlobalmemref.Globalmemref.Loadmemref.Storescf.YieldPreviously discussed with @AntonLydike and @n-io