Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix codecov #2650

Merged
merged 5 commits into from
Jun 6, 2024
Merged

ci: fix codecov #2650

merged 5 commits into from
Jun 6, 2024

Conversation

superlopuh
Copy link
Member

@superlopuh superlopuh commented May 28, 2024

As recommended here:
codecov/feedback#388

This PR makes it such that checkout fetches the two prior commits, to show the diff.

@superlopuh superlopuh added the CI Continuous Integration label May 28, 2024
@superlopuh superlopuh self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (a173190) to head (13cc11b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
+ Coverage   89.61%   89.64%   +0.02%     
==========================================
  Files         360      361       +1     
  Lines       46209    46252      +43     
  Branches     6986     6992       +6     
==========================================
+ Hits        41410    41462      +52     
+ Misses       3724     3719       -5     
+ Partials     1075     1071       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh marked this pull request as ready for review May 28, 2024 20:57
@math-fehr
Copy link
Collaborator

@superlopuh, is this working (i.e, can I merge it?)

@superlopuh
Copy link
Member Author

No, please see discussion on linked issue in codecov, this PR is useful for me to keep debugging the problem. It seems like merging it would still be a good move, though, I'll hit the button and maybe open more PRs to get to the bottom of the issue.

@superlopuh superlopuh merged commit 2adb193 into main Jun 6, 2024
19 checks passed
@superlopuh superlopuh deleted the sasha/codecov branch June 6, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants