Updated cats and monix dependencies #69
Conversation
ilya-murzinov
force-pushed
the
dependency-update
branch
from
183c76d
to
b6e8543
Compare
| ): FetchMonadError[Future] = new FetchMonadError[Future] { | ||
| override def runQuery[A](j: Query[A]): Future[A] = j match { | ||
| case Sync(e) => ME.pureEval(e) | ||
| case Sync(e) => pure(e.value) |
There was a problem hiding this comment.
We were before abusing pureEval to lift lazy computations potentially effectful to M[_] but this will eagerly evaluate them and place the result in M which is not what we want for Future and others.
We need something in the lines of...
@typeclass trait Capture[F[_]] {
def capture[A](a :=> A) : F[A]
}with instances for the supported target M[_], so computation are lazily placed inside context that can capture effects.
There was a problem hiding this comment.
@raulraja thanks for the hint!
Is is possible that this change is causing tests to fail?
[info] - Every level of joined concurrent fetches is combined and batched *** FAILED ***
[info] (1,1,6) did not equal (3,3,6) (FetchTests.scala:481)
[info] - The product of concurrent fetches of the same type implies everything fetched in a single batch *** FAILED ***
[info] (1,1,4) did not equal (2,1,4) (FetchTests.scala:457)
[info] - Every level of sequenced concurrent of concurrent fetches is batched *** FAILED ***
[info] (5,5,19) did not equal (3,3,19) (FetchTests.scala:508)
There was a problem hiding this comment.
Thanks for taking the time to make these changes Ilya, I've made some changes to the fetch execution reporting that should make those errors go away in the reporting branch. I'm going to try to combine your work and mine and cut a release as soon as possible.
There was a problem hiding this comment.
@dialelo ooooops, I didn't see that it' already implemented in your branch :(
|
Seems that this PR is useless since it's already implemented in #66 |
|
@dialelo I'll leave this PR open in case you'll find anything useful in it. But feel free to close it :) |
ghost
closed this
As requested in #68
Tests are failing right now, I'll fix them