Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] - Gradle problem in buildAndTestSinglep and buildAndTestMultip #543

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

tomascayuelas
Copy link
Contributor

@tomascayuelas tomascayuelas commented Nov 15, 2023

Fix the problem with Gradle executing more than two exec commands.

A Gradle Exec task will only run the last ‘commandLine’ defined inside its block. Putting multiple entries inside its block will not run multiple commands.

Before we only execute the xef-tokenizer module due to this behaviour. Now we execute all the modules.

I want to continue investigating if we can reduce times.

@tomascayuelas tomascayuelas marked this pull request as ready for review November 15, 2023 15:42
@tomascayuelas tomascayuelas self-assigned this Nov 15, 2023
Montagon
Montagon previously approved these changes Nov 15, 2023
Copy link
Contributor

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, @tomascayuelas!! 🚀

@tomascayuelas tomascayuelas merged commit 934284d into main Nov 15, 2023
5 checks passed
@tomascayuelas tomascayuelas deleted the fix/gradle-build-and-test branch November 15, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants