Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene as vector store #59

Merged
merged 4 commits into from
May 15, 2023
Merged

Lucene as vector store #59

merged 4 commits into from
May 15, 2023

Conversation

serras
Copy link
Contributor

@serras serras commented May 15, 2023

Apache Lucene is a more performant alternative to indexing that our current version based on a Map. In theory it should be able to perform similarity searches without even having to request an Embedding, but unfortunately the current interface requires us to provide a version of search from one such embedding.

@serras serras requested a review from raulraja May 15, 2023 08:43
@serras serras self-assigned this May 15, 2023
@juanpedromoreno
Copy link
Contributor

On another note, I suggest creating separate modules for "optional" integrations instead of adding this dependency to the core, as it may result in many transitive dependencies.

@serras
Copy link
Contributor Author

serras commented May 15, 2023

On another note, I suggest creating separate modules for "optional" integrations instead of adding this dependency to the core, as it may result in many transitive dependencies.

Makes complete sense. I've split it into a new module langchain4k-lucene.

Maybe we should do the same with the PostgreSQL one...

Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@serras serras merged commit 2937da5 into main May 15, 2023
1 check passed
@serras serras deleted the as-lucene-vectorstore branch May 15, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants