Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Support #11

Closed
rwilliams opened this issue May 12, 2017 · 7 comments
Closed

Windows Support #11

rwilliams opened this issue May 12, 2017 · 7 comments

Comments

@rwilliams
Copy link

PTY is not available on Windows builds of ruby. Is something like this relevant to adding Windows support given how backticks currently utilizes PTY?

@xeger
Copy link
Owner

xeger commented May 19, 2017

Backticks only uses the PTY module when using unbuffered mode. Unbuffered mode is the default, but if you construct your own Runner, then it's posible to ask for buffered operation, which utilizes IO.pipe instead of PTY. I think IO.pipe is supported under Win32 MRI, but I lack a Windows system to experiment on.

If you're willing to do some testing for me, I'll produce an experimental branch that "supports" Windows but which only performs buffered execution. You'll need to know how to use Bundler to point to the experimental branch, but that's straightforward. Interested?

@rwilliams
Copy link
Author

I can test it for you.

@xeger
Copy link
Owner

xeger commented May 19, 2017

Great. The branch is named no-pty and you can use it by putting this in your Gemfile:

gem 'backticks',
  git: 'https://github.com/xeger/backticks',
  branch: 'no-pty'

@rwilliams
Copy link
Author

Awesome. I'll give it a spin this weekend.

@xeger
Copy link
Owner

xeger commented Aug 7, 2017

Bump Any luck with the no-pty branch in Windows?

@rwilliams
Copy link
Author

I haven't been able to rip out all the posix stuff in my gem yet to really thrash backticks yet but so far it looks good. Thanks for your quick patch on this.

xeger pushed a commit that referenced this issue Aug 8, 2017
@xeger xeger closed this as completed in 077dc9d Aug 8, 2017
@xeger
Copy link
Owner

xeger commented Aug 8, 2017

I published backticks v1.0.1 with your fix; thanks for reporting + testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants