Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #14

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Fix warnings #14

merged 2 commits into from
Oct 16, 2017

Conversation

dsander
Copy link
Contributor

@dsander dsander commented Oct 13, 2017

Fixes two ruby warnings:

warning: instance variable @something not initialized

and

assigned but unused variable something

Fixes two ruby warnings:

`warning: instance variable @something not initialized`

and

`assigned but unused variable something`
@coveralls
Copy link

coveralls commented Oct 13, 2017

Coverage Status

Coverage decreased (-0.3%) to 95.033% when pulling 225ee99 on dsander:fix-warnings into 077dc9d on xeger:master.

@xeger
Copy link
Owner

xeger commented Oct 16, 2017

Good work; thank you. It looks like the warnings are only emitted during RSpec runs, hence, no need to publish a new version. Correct?

@xeger xeger merged commit 225ee99 into xeger:master Oct 16, 2017
@dsander
Copy link
Contributor Author

dsander commented Oct 16, 2017

Thanks for creating the gem! I noticed the errors when I ran specs which used backticks. Even though it used the same RSpec version I did not even need to explicitly enable warnings, not sure why that was required in the specs here.
I guess one would also get the warnings if a one enables warnings for ruby in general. I am good with having a monkey match for now 😄

@xeger
Copy link
Owner

xeger commented Oct 16, 2017 via email

@xeger
Copy link
Owner

xeger commented Oct 20, 2017

FYI @dsander, I published v1.0.2 with your fixes.

@dsander
Copy link
Contributor Author

dsander commented Oct 21, 2017

Thank you!

@dsander dsander deleted the fix-warnings branch October 21, 2017 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants