Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 18 #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katherinejensen00
Copy link

Update dependency from React 17 to React 18

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for xelah-core canceled.

Name Link
🔨 Latest commit 768b898
🔍 Latest deploy log https://app.netlify.com/sites/xelah-core/deploys/6462a251224ac60008937e03

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for xelah-type-perf-html ready!

Name Link
🔨 Latest commit 768b898
🔍 Latest deploy log https://app.netlify.com/sites/xelah-type-perf-html/deploys/6462a251920e5c000899b3bf
😎 Deploy Preview https://deploy-preview-28--xelah-type-perf-html.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@klappy
Copy link
Collaborator

klappy commented May 22, 2023

Thanks for the PR @katherinejensen00! Did you have trouble using this in your React 18 app? Originally I had it set to 18 but downgraded for cross-compatibility with some of our existing React 17 apps. This should still work in your React 18 environment. I'll check with others to see if they see any issues with upgrading.

@samueljd, @larsgson, @abelpz, and @joelthe1 Do you know what version of React that your implementations are using? Do you see any issues if we upgraded the version of React to 18? Anybody available to help guide the PR review for the monorepo dependency update?

@katherinejensen00
Copy link
Author

Hi @klappy, yes I did run into an error trying to use Xelah in a project using React 18. I am newer to React so it is possible there is an easier solution than updating Xelah. Here is the error I am seeing:
image

@larsgson larsgson closed this Sep 27, 2023
@larsgson larsgson reopened this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants