Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of image IO should use std::vector #67

Closed
xelatihy opened this issue Oct 13, 2018 · 1 comment
Closed

Implementation of image IO should use std::vector #67

xelatihy opened this issue Oct 13, 2018 · 1 comment
Labels
enhancement

Comments

@xelatihy
Copy link
Owner

Internal functions for loading and saving images should use std::vector instead of raw pointers for safety.
@xelatihy
Copy link
Owner Author

xelatihy commented Oct 13, 2018 •
edited

The tasks that needs doing are

  • change the internal API for read_pfm
  • add a wrapper for stbi
  • add a wrapper fir TinyEXR
  • catch io errors In the wrappers

@xelatihy xelatihy mentioned this issue Oct 13, 2018
Merged
xelatihy added a commit that referenced this issue Oct 13, 2018
@xelatihy
Image IO uses safe wrappers with logging (#73)
54daf6c 
Image IO uses safe wrappers with logging. Fixes #67.
xelatihy added a commit that referenced this issue Nov 22, 2018
@xelatihy
Image IO uses safe wrappers with logging (#73)
b6fc71e 
Image IO uses safe wrappers with logging. Fixes #67.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xelatihy