Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALFREDAPI-519: Update Maven badge to alfred.api #188

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

WimCrols
Copy link
Collaborator

@WimCrols WimCrols commented Dec 4, 2023

Fixes https://xenitsupport.jira.com/browse/ALFREDAPI-519

  • Is CHANGELOG.md extended?
  • Does this PR avoid breaking the API?
    Breaking changes include adding, changing or removing endpoints and/or JSON objects used in requests and responses.
  • Does the PR comply to REST HTTP result codes policy outlined in the user guide?
  • Is error handling done through a method annotated with @ExceptionHandler in the webscript classes?
  • Does the PR follow our coding styleguide and other active procedures?
  • Is usage of this. prefix avoided?

See README.md for full explanation.

@WimCrols
Copy link
Collaborator Author

WimCrols commented Dec 4, 2023

Forgot to update this in #185

Copy link

@Brobrechts Brobrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current links don't resolve.

I'm assuming, because of the rename, it will only work after it's been published?
So we got ourselves a chicken and the egg problem

@WimCrols
Copy link
Collaborator Author

@Brobrechts The group id is changed to indicate the switch from DE to MVC, but there has not been a release yet. It's indeed a bit of a chicken and an egg. I still would like to do a release this year.

@WimCrols WimCrols merged commit cc90a41 into master Dec 12, 2023
10 checks passed
@WimCrols WimCrols deleted the ALFREDAPI-519/alf74-readme branch December 12, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants