[ALFREDAPI-554] make service beans available in main application context #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvriel
commented
Jun 14, 2024
pvriel
commented
Jun 14, 2024
pvriel
commented
Jun 14, 2024
WimCrols
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://xenitsupport.jira.com/browse/ALFREDAPI-554
Problem: Alfred API's service beans (e.g. ISearchService) are present in a separate child application context, making them unavailable for AMPs to be used.
This PR makes the beans of the
apix-implsubproject available in the main application context of Alfresco, which Alfresco also uses when initializing beans of AMPs.Note to the reviewer: I noticed that running the
testGradle task does not work. The following problems occur:TypeServiceUnitTest:
- testGetTypeDefinition_returnsNull_whenQnameInvalid
SetMetadataUnitTest:
- testGeneralizeTypeWithCleanUpEnabled
- testGeneralizeTypeWithCleanUpdisabled
SearchFacetServiceUnitTest:
- assertThat_getFacetResults_returnIncludes_translationsForListOfValueConstraints
SearchServiceUnitTest:
- all tests, except for testDefaultSearchQueryConsistencyIsTransactionalIfPossible
However, I noticed the same problem when running these tests on the master branch. These errors do not represent a new bug introduced by this PR.