Server key did not validate when hashed known host entry is present

[sverhoeven]

I did:

rm ~/.ssh/known_hosts
docker run --detach --publish 10022:22 nlesc/xenon-ssh
ssh-copy-id xenon@localhost -p 10022
ssh xenon@localhost -p 10022 hostname

In my ~/.ssh/known_hoststhere is now a hashed entry forlocalhost:10022`.

When I try to create a scheduler with

Scheduler scheduler = Scheduler.create("ssh", "localhost:10022", new DefaultCredential("xenon"));

Xenon throws a org.apache.sshd.common.SshException: Server key did not validate exception.

[sverhoeven]

Found bug in SSHD client, it hashes the hostname only, ignoring the port.

The bug can be workaround by creating a copy of KnownHostEntry.isHostMatch() and changing it to

        if (super.isHostMatch(host, port)) {
            return true;
        }

        KnownHostHashValue hash = getHashedEntry();
        if (port == 22) {
            return (hash != null) && hash.isHostMatch(host);
        } else {
            return (hash != null) && hash.isHostMatch("[" + host + "]:" + port);
        }

[sverhoeven]

Bug is still present in latest mina-sshd 2.1.0, see https://github.com/NLeSC/Xenon/tree/mina-2.1.0 branch.

Create issue https://issues.apache.org/jira/browse/SSHD-852 to get it fixed in mina-sshd.

[sverhoeven]

Fix has been merged apache/mina-sshd@326725d, waiting for new release >v2.1.0 of mina sshd so we can upgrade the dependency.

[jmaassen]

Great!

[sverhoeven]

Now using Mina sshd 2.2.0, so it is fixed.