Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurm multi version #492

Merged
merged 8 commits into from
Jul 31, 2017
Merged

Slurm multi version #492

merged 8 commits into from
Jul 31, 2017

Conversation

jspaaks
Copy link
Member

@jspaaks jspaaks commented Jul 25, 2017

The code in this pull request is meant to be tested against images from this pull request xenon-middleware/xenon-docker-images#16

@sverhoeven
Copy link
Member

Java code looks OK.

CI builds fail due to images not being found.

After xenon-middleware/xenon-docker-images#16 is merged and Automated Build has been setup then this PR can be retested and merged.

@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #492 into master will decrease coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
- Coverage     78.83%   78.82%   -0.01%     
- Complexity     1326     1327       +1     
============================================
  Files           101      101              
  Lines          4360     4364       +4     
  Branches        639      640       +1     
============================================
+ Hits           3437     3440       +3     
- Misses          735      736       +1     
  Partials        188      188
Flag Coverage Δ Complexity Δ
#fixedclientenvironment 21.65% <0%> (-0.02%) 349 <0> (ø)
#integration 50.84% <71.42%> (-0.24%) 748 <8> (-4)
#livelocal 7.76% <0%> (-0.01%) 129 <0> (ø)
#unit 52.86% <0%> (+0.06%) 961 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
...enon/adaptors/schedulers/slurm/SlurmScheduler.java 68.96% <71.42%> (-0.54%) 32 <8> (ø)
...nl/esciencecenter/xenon/utils/StreamForwarder.java 76.92% <0%> (+1.92%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19f15b...b4cbcd6. Read the comment docs.

@jmaassen jmaassen merged commit 34607a4 into master Jul 31, 2017
@jmaassen jmaassen deleted the slurm-multi-version branch July 31, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants