Allow more shaped recipe sizes #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelnCat
force-pushed
the
feat/fix-shaped-recipes
branch
from
14a457e
to
55a130c
Compare
NichtStudioCode
requested changes
Dec 25, 2022
There was a problem hiding this comment.
You're not using our codestyle.
You just copied decompiled Minecraft code, which is (due to being decompiled code) very hard to read and overly complex.
nova/src/main/kotlin/xyz/xenondevs/nova/data/recipe/NovaCraftingRecipes.kt
Outdated
Show resolved
Hide resolved
nova/src/main/kotlin/xyz/xenondevs/nova/data/recipe/NovaCraftingRecipes.kt
Outdated
Show resolved
Hide resolved
nova/src/main/kotlin/xyz/xenondevs/nova/data/recipe/NovaCraftingRecipes.kt
Outdated
Show resolved
Hide resolved
|
Code has been refactored and reriiten |
NichtStudioCode
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Nova only supports 3x3 shaped recipes. However, vanilla and bukkit actually supports many other shapes natively, such as 2x3, 3x2, 3x1, 1x3, etc. This pull request allows Nova to take advantage of the native recipe sizes, and allows other shaped recipe sizes to be used.