Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tags as recipe choices in recipes #221

Merged
merged 4 commits into from
Dec 26, 2022

Conversation

MelnCat
Copy link
Contributor

@MelnCat MelnCat commented Dec 26, 2022

This allows recipes to use the built in Minecraft tags in recipe ingredients. This makes it significantly easier to create recipes with certain ingredients, such as an "any plank" recipe choice, "any stair", etc.

For example, previously, to make a recipe that used any planks, the recipe would look similar to this:

{
  "result": "placeholder:placeholder",
  "shape": [
    "www",
    "wsw",
    "www"
  ],
  "ingredients": {
    "w": ["minecraft:oak_planks","minecraft:birch_planks","minecraft:spruce_planks", "minecraft:jungle_planks", ...etc],
    "s": "minecraft:stone"
  }
}

Now with this pull request, it can be written as:
This allows recipes to use the built in Minecraft tags in recipe ingredients. This makes it significantly easier to create recipes with certain ingredients, such as an "any plank" recipe choice, "any stair", etc.

For example, previously, to make a recipe that used any planks, the recipe would look similar to this:

{
  "result": "placeholder:placeholder",
  "shape": [
    "www",
    "wsw",
    "www"
  ],
  "ingredients": {
    "w": "#minecraft:planks",
    "s": "minecraft:stone"
  }
}

Using the #planks tag (https://minecraft.fandom.com/wiki/Tag#Items).

Copy link
Member

@ByteZ1337 ByteZ1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NichtStudioCode NichtStudioCode merged commit c305077 into xenondevs:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants