migrate to JUnit 5 #649
migrate to JUnit 5 #649
Conversation
| @Test(expected = SQLException.class) | ||
| public void reproduceDatabaseLocked() throws SQLException | ||
| { | ||
| @Disabled("Not sure this worked recently, the second query cannot find the table 'sample'") |
There was a problem hiding this comment.
Note that i had to disable this test.
In JUnit 4 the way to assert that an exception is thrown is to use expected in the @Test declaration, but that doesn't ensure the exception was thrown at the right place.
For this test ResultSet rs = stat2.executeQuery("select count(*) from sample"); throws an exception because the table sample cannot be found.
I think the test passed in JUnit 4, but for the wrong reason.
|
@xerial this is a requirement to automate GraalVM native tests |
|
Thanks for cleaning up tests. It seems we need to introduce some code formatter :) |
Yes indeed that would help, and maybe some enforcers or quality check. Any tool you had experience with that you would like better than another? |
Migrating all tests to JUnit 5 using the Jupiter engine.
This also removes the need to declare test classes in
AllTests.java, which for instance was overlooked on my collation PR (#627), thus tests were not running when runningmvn test.