-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the optional k8s-version flag to cobra #230
base: master
Are you sure you want to change the base?
Add the optional k8s-version flag to cobra #230
Conversation
Signed-off-by: Waleed Gadelkareem <gadelkareem@gmail.com>
IMHO should be a nice starting point, I think some more changes are needed:
IMHO this should be a breaking change, so we should dump version and maybe we can consider to implement it in 0.4 where @xetys is considering to allow to have support to the K8s 1.12 (see #208), but I'm not sure we will support multiple cluster version in the application at the first iteration. PS: @gadelkareem thx for ALL your contribution to this project :) |
@mavimo and thanks for great project ;)
Seems like 1.10 is working! Let me do some more tests and come back to you on this. |
Signed-off-by: Waleed Gadelkareem <gadelkareem@gmail.com>
Signed-off-by: Waleed Gadelkareem <gadelkareem@gmail.com>
So only v1.10* worked for me and seems to be as stable as 1.9 so far. So it is kinda good news still! I updated the docs to add the new flag and add it to the cluster config |
Update master
# Conflicts: # pkg/clustermanager/cluster.go
fixes #162
Although this enables the k8s-version flag. It is not currently possible to switch k8s version because of the related config.