Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the optional k8s-version flag to cobra #230

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

gadelkareem
Copy link
Contributor

@gadelkareem gadelkareem commented Nov 20, 2018

fixes #162

Although this enables the k8s-version flag. It is not currently possible to switch k8s version because of the related config.

@mavimo
Copy link
Collaborator

mavimo commented Nov 21, 2018

IMHO should be a nice starting point, I think some more changes are needed:

  • Update README to allow to specify what value are accepted, until now I think the cluster should be accept 1.9.X, 1.10.X and 1.11.X since config format is unchanged in this versions (as far I remember), but we should do some more checks
  • E2E test should be added to allow to deploy a cluster for each supported version (maybe a small cluster for each version should be fine)
  • Config should store the cluster version and it should be restored on load in order to apply consistent behaviour when needed

IMHO this should be a breaking change, so we should dump version and maybe we can consider to implement it in 0.4 where @xetys is considering to allow to have support to the K8s 1.12 (see #208), but I'm not sure we will support multiple cluster version in the application at the first iteration.

PS: @gadelkareem thx for ALL your contribution to this project :)

@gadelkareem
Copy link
Contributor Author

gadelkareem commented Nov 21, 2018

@mavimo and thanks for great project ;)

I actually did test it but unfortunately all versions failed. That's why it is a good idea to leave it out of the docs for now and merge it for new upcoming versions.

Seems like 1.10 is working! Let me do some more tests and come back to you on this.

Signed-off-by: Waleed Gadelkareem <gadelkareem@gmail.com>
Signed-off-by: Waleed Gadelkareem <gadelkareem@gmail.com>
@gadelkareem
Copy link
Contributor Author

gadelkareem commented Nov 22, 2018

So only v1.10* worked for me and seems to be as stable as 1.9 so far. So it is kinda good news still!

I updated the docs to add the new flag and add it to the cluster config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes version select
2 participants