Replace tmpdir with tmp_path in tests #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 466 467 +1
=========================================
+ Hits 466 467 +1
Continue to review full report at Codecov.
|
|
Thank your for the review, everything updated. Should I squash it to a single commit or do you want to do it in the merge? |
xflr6
reviewed
Jan 18, 2021
pytest's tmpdir uses py.path which is in maintenance mode. Everyone, pytest included, is migrating to tmp_path returning a stdlib's pathlib.Path object. I also moved the test data file dot_red.png to an extra testdata directory.
|
@xflr6 thank you for the review, I have committed your latest notes as well and squashed to a single commit with a longer description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #125, this replaces
tmpdirwithtmp_pathin all tests (andtmpdir_factorywithtmp_path_factory), because thepy.pathused astmpdiris in maintenance mode andpytestis also migrating totmp_path.This adds some code though because
py.pathhad special functions for almost everything and here they have to be supplied withosandshutil.Next step would be replacing all
os.path/glob/opencalls in the main code withpathlib.Path.