Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop mock_use_standalone_module #155

Closed

Conversation

eclipseo
Copy link

Mock is integrated to Python as unittest.mock since version 3.6 so importing mock is no longer necessary.

See https://github.com/testing-cabal/mock/blob/master/README.rst
and https://github.com/pytest-dev/pytest-mock/blob/main/src/pytest_mock/_util.py#L17

Mock is integrated to Python as unittest.mock since version 3.6 so importing mock is no longer necessary.

See https://github.com/testing-cabal/mock/blob/master/README.rst
and https://github.com/pytest-dev/pytest-mock/blob/main/src/pytest_mock/_util.py#L17
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #155 (d33fab7) into master (44f5b0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines         1079      1079           
=========================================
  Hits          1079      1079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f5b0a...d33fab7. Read the comment docs.

@xflr6
Copy link
Owner

xflr6 commented Dec 18, 2021

Thanks for the PR.

We use https://pypi.org/project/mock/ in tests in order to make use of the latest mock features across Python versions:

This package contains a rolling backport of the standard library mock code compatible with Python 3.6 and up.

See the failing tests under Python 3.7 from mock.call_args.kwargs added in Python 3.8.

@xflr6 xflr6 closed this Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants