This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
My Documents mods-folder support #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes will add a new optional mods folder in the system users documents directory. If "My Documents/Anno 1800/mods" exists, ModManager::GetModsDirectory will now return this location as the mods folder. This way the modloader will be backward compatible but also supports system user based mods, non privileged apps can access the mods folder and mods can be synced by cloud services like onedrive.
additional info regarding the ability to use symlinks
|
Thanks. I have a few nit-picks that I will fix outside of this PR locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes will add a new optional mods folder in the system users documents directory.
If "My Documents/Anno 1800/mods" exists, ModManager::GetModsDirectory will now return this location as the mods folder.
This way the modloader will be backward compatible but also supports system user based mods, non privileged apps can access the mods folder and mods can be synced by cloud services like onedrive.
PR includes the README chanegs