Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error in stats #552

Closed
nwlandry opened this issue Jun 9, 2024 · 2 comments · Fixed by #561
Closed

Possible error in stats #552

nwlandry opened this issue Jun 9, 2024 · 2 comments · Fixed by #561

Comments

@nwlandry
Copy link
Collaborator

nwlandry commented Jun 9, 2024

In this line in the constructor of IDStat, there is this line:

self.kwargs = {} if args is None else kwargs

Shouldn't it be kwargs?

@leotrs
Copy link
Collaborator

leotrs commented Jun 9, 2024 via email

@nwlandry nwlandry mentioned this issue Jul 11, 2024
@nwlandry
Copy link
Collaborator Author

Hi @leotrs --- I tried my best to create an issue, but I can't create an example which will raise undesired behavior. Nonetheless, I think my PR makes the code more explainable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants