Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix networkx issue #268

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Fix networkx issue #268

merged 4 commits into from
Jan 10, 2023

Conversation

nwlandry
Copy link
Collaborator

Made XGI compatible with NetworkX 3.0 and changed use of scipy sparse matrices to scipy sparse arrays.

@nwlandry nwlandry linked an issue Jan 10, 2023 that may be closed by this pull request
NetworkX 3.0 breaks XGI #267
Closed
@maximelucas
Copy link
Collaborator

Nice! Thanks Nich.
I remember we used to have a warning because of the csr_matrix being obsolete, and I think we did something somewhere to not see it anymore. We could remove it now. Anyone remembers where?

@nwlandry
Copy link
Collaborator Author

I believe that it was in multiorder_laplacian() but I don't see it anymore.

@nwlandry nwlandry merged commit 745c906 into main Jan 10, 2023
@nwlandry nwlandry deleted the fix-networkx-issue branch January 10, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leotrs leotrs leotrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkX 3.0 breaks XGI
3 participants
@nwlandry @maximelucas @leotrs