-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return axes #300
Return axes #300
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 83.41% 84.29% +0.87%
==========================================
Files 35 35
Lines 2732 2751 +19
==========================================
+ Hits 2279 2319 +40
+ Misses 453 432 -21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Look great, thanks. The renaming is a good idea. Do you think the codecov/patch is failing because your new PCA function is not tested? Could you add an example of how to use the PCA function in the notebook? |
All your comments should be addressed now! Added unit tests and an example in Tutorial 5. |
Left one more minor comment. Also the notebook for tutorial 5 has all outputs cleared. And the codecov test is still failing. I think because our codecov has slightly decrease with the PR? |
I looked up how to fix the issue and hopefully the configuration file that I added will fix the error. The issue is that even though this PR increases the coverage, it edits code that doesn't have any coverage so it treats it like I just committed a bunch of code without tests. |
Yea that's what I understood too. |
Updated the plotting functions:
xgi_pylab.py
todraw.py
.draw_xgi_nodes
becamedraw_nodes
,draw_xgi_hyperedges
becamedraw_hyperedges
, anddraw_xgi_simplices
becamedraw_simplices
.pca_transform
function which can be used to control the rotation of the drawing relative to the principal axes.