-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure folder for generators and linalg #321
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 90.29% 90.35% +0.05%
==========================================
Files 36 41 +5
Lines 2926 2954 +28
==========================================
+ Hits 2642 2669 +27
- Misses 284 285 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
It's already big enough to review I'd say. Done:
To do:
|
Overall, looks good! Some high-level things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if I like the "hypergraph_matrix.py" name. Maybe break this into "incidence" and "adjacency"? But of course the intersection profile and degree matrices don't clearly belong to either. My concern is that these matrices aren't exclusively for hypergraphs in the way that we set them up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exclusively for hypergraphs in the sense that they also work for simplicial complexes? But SCs are HGs O:)
We could just call it "matrix.py", or "structure". It's not so clear how to break into less than 5 files indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! A lot of good stuff here. I would say that the big thing is to add docs for the restructured files and there's just a few comments. Nice work!
5e438a0
to
074cb82
Compare
Hi @maximelucas - I had the opportunity to look over this PR and looks great! I hope you don't mind that I did the following:
|
Perfect, thanks Nich! |
Following #319