-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt at fixing convert #345
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 90.39% 90.42% +0.03%
==========================================
Files 41 41
Lines 2988 3008 +20
==========================================
+ Hits 2701 2720 +19
- Misses 287 288 +1
☔ View full report in Codecov by Sentry. |
fix clash created in previous commit
Hi @thomasrobiglio ! Thanks so much for your work on this. We'll review it soon and get back to you. |
Also linked to #330 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just a few minor nitpicks that would make me very happy if you could respond to :)
Thank you @thomasrobiglio ! We hope to see more of your contributions in the future. If you're interested in keeping up with development, feel free to join us on Zulip! |
Hi all,
this is my attempt at addressing issue #327 and some other troubles I've found using the functions in the
convert.py
file.Now it should be possible to:
from_max_simplices
and an analogous criterion when going from the other way around i.e. hyperdges -> maximal faces then i had all subfaces)Hopefully this is what you had in mind when discussing #327 and this can be a useful contribution.