Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx #350

Merged
merged 7 commits into from
May 4, 2023
Merged

Update sphinx #350

merged 7 commits into from
May 4, 2023

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented May 4, 2023

  • Up-version sphinx to v6.xxx
  • Up-version sphinx-rtd-theme to >= 1.2 to be compatible with Sphinx v6.xxx.
  • I added a more organized and concrete contribution guide and eliminated some redundancy in the GH, PyPI, and RTD landing pages. Hopefully this addresses the reviewer's comments in our JOSS submission.

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (5497778) 90.36% compared to head (8519ac8) 90.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   90.36%   90.43%   +0.07%     
==========================================
  Files          41       41              
  Lines        2988     3012      +24     
==========================================
+ Hits         2700     2724      +24     
  Misses        288      288              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nwlandry nwlandry merged commit 591d681 into main May 4, 2023
@nwlandry nwlandry deleted the update-sphinx branch May 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants