-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New layouts #360
New layouts #360
Conversation
wrote explicitly the circular layout and the spiral layout.
added center in spiral
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 90.49% 90.58% +0.09%
==========================================
Files 41 41
Lines 3020 3060 +40
==========================================
+ Hits 2733 2772 +39
- Misses 287 288 +1
☔ View full report in Codecov by Sentry. |
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
This is great, thanks a lot Thomas. Just let a few minor comments. Could you also add the new functions to the plotting tutorial? |
Thank you max, i'll check all the comments in a bit. I did not put the new layouts in the tutorial because I was thinking we should open an issue to discuss how we want to re-organize the tutorial. |
You're right we wanted to reorganise the tutorials. You can still add it now but otherwise we'll add it when we organise them no worries. Thank!! |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@maximelucas I've just pushed the files with your comments (thx) + a simple cell in the drawing tutorial (tutorial 05). Let me know if I need to add other test to solve the ☂️ , else I'll let you merge the PR. |
Thanks Thomas! |
+ minor fix in test (missing line in test_pairwise_spring_layout()) + coherence in docstrings + run black
as in main
As discussed in #359.
Added circular layout, spiral layout and
barycenter_kamada_kawai_layout
that does the same asbarycenter_spring_layout
but with a different cost function (implemented in networkx).