Views should be read-only #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
+ Coverage 90.58% 90.74% +0.16%
==========================================
Files 41 42 +1
Lines 3060 3113 +53
==========================================
+ Hits 2772 2825 +53
Misses 288 288
☔ View full report in Codecov by Sentry. |
|
Nice! Could you add a quick test for that? |
Good point! Just did. |
maximelucas
approved these changes
May 21, 2023
leotrs
reviewed
May 22, 2023
Comment on lines
+170
to
+180
| # test that members are copies in memory | ||
| H.edges.members(0).add("a") | ||
| assert "a" not in H.edges.members(0) | ||
|
|
||
| e = H.edges.members() | ||
| e[0].add("a") | ||
| assert "a" not in H.edges.members(0) | ||
|
|
||
| e = H.edges.members(dtype=dict) | ||
| e[0].add("a") | ||
| assert "a" not in H.edges.members(0) |
There was a problem hiding this comment.
I'd rather this be a separate test :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug where
H.edges.members()creates a list with entries that are references toH._edgeand so modifyingH.edges.members()modifies the internal data structure. Same withH.nodes.memberships(). Also modified a few of the docstrings.