Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed math that was not represented properly. #381

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fixed math that was not represented properly. #381

merged 1 commit into from
Jun 5, 2023

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Jun 5, 2023

I converted math expressions to Sphinx so that it rendered properly.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f22c455) 91.11% compared to head (2938f68) 91.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #381   +/-   ##
=======================================
  Coverage   91.11%   91.11%           
=======================================
  Files          46       46           
  Lines        3771     3771           
=======================================
  Hits         3436     3436           
  Misses        335      335           
Impacted Files Coverage Δ
xgi/algorithms/centrality.py 97.39% <ø> (ø)
xgi/classes/dihypergraph.py 98.31% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nwlandry nwlandry merged commit 5b2cc16 into main Jun 5, 2023
@nwlandry nwlandry deleted the fix-math branch June 5, 2023 15:06
@maximelucas
Copy link
Collaborator

Good catch! Just noticed node_edge_centrality renders maths poorly too

@thomasrobiglio
Copy link
Collaborator

also line_vector_centrality and clustering_coefficient

@nwlandry
Copy link
Collaborator Author

nwlandry commented Jun 5, 2023

Ahhhh darn. Thanks for catching those and I'll make a new PR without rushing this time. :)

@nwlandry
Copy link
Collaborator Author

nwlandry commented Jun 5, 2023

@thomasrobiglio - I couldn't locate the math error in line_vector_centrality. Could you send me a line number or snippet so I can locate it? Thanks!

@thomasrobiglio
Copy link
Collaborator

actually it was a false alarm (sry) but something is wrong with the docs because it does this:
Screenshot 2023-06-05 alle 17 38 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants