bug fix for draw_dihypergraph #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: ability to handle integer nodes and isolated nodes test: test for DH with str node labels and isolated nodes style: run black
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
- Coverage 91.02% 90.95% -0.07%
==========================================
Files 47 47
Lines 3878 3882 +4
==========================================
+ Hits 3530 3531 +1
- Misses 348 351 +3
☔ View full report in Codecov by Sentry. |
|
Thank you @leotrs, I should have addressed your comments. |
leotrs
approved these changes
Jun 9, 2023
|
Looks great, @thomasrobiglio! Good to merge! I have an unrelated issue on the layout that I'll raise in an issue. |
nwlandry
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #393, I have also noticed that the previous implementation would raise an error with isolated nodes. This should fix both the problems (string nodes and isolated nodes).
fix: ability to handle integer nodes and isolated nodes
test: test for DH with str node labels and isolated nodes
style: run black