Convert from simplex dict to SC #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
- Coverage 90.95% 90.94% -0.02%
==========================================
Files 47 47
Lines 3882 3888 +6
==========================================
+ Hits 3531 3536 +5
- Misses 351 352 +1
☔ View full report in Codecov by Sentry. |
leotrs
approved these changes
Jun 12, 2023
nwlandry
reviewed
Jun 13, 2023
There was a problem hiding this comment.
Great work, @thomasrobiglio! I just tried it out and it works well! Good to squash and merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #330 (the ability for the SC constructor to handle a HG was already implemented, this PR is about #330 (comment)).
I added a new function
from_simplex_dictthat takes a dict in the form:{edge_id: members, ...}and returns a SC. If the subfaces of existing simplices are not given in the dict then the function adds them with integer IDs.