-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes and corrections to tutorials in the API #479
Conversation
*added missing focus tutorials *added hyperedges in depth tutorial
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 60 60
Lines 4392 4392
=======================================
Hits 4043 4043
Misses 349 349 ☔ View full report in Codecov by Sentry. |
This should be ready now. @maximelucas I made a small addition in the in depth tutorial about the edges, in the end when you show how to combine this with the nodes. I think you wanted to say that you can combine drawing nodes and edgesusing |
@@ -57,20 +57,7 @@ | |||
"outputs": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -57,20 +57,7 @@ | |||
"outputs": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -57,20 +57,7 @@ | |||
"outputs": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was in Yoda mode
@@ -11,7 +11,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -11,7 +11,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ax, collections = xgi.draw(H, pos=pos, dyad_color=link_color, edge_fc_cmap=cmap)
edge_collection = collections[-1]
plt.colorbar(edge_collection)
Reply via ReviewNB
Hero 🏇🏻 |
*added missing focus tutorials #475
*added hyperedges in depth tutorial to API #456
I will also add a recipe for the coloring of hyperedges (as suggested in #478) + do minor changes correcting typos and imprecisions.