-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to draw hypergraphs as a bipartite graph #492
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 92.16% 92.29% +0.13%
==========================================
Files 60 60
Lines 4418 4493 +75
==========================================
+ Hits 4072 4147 +75
Misses 346 346 ☔ View full report in Codecov by Sentry. |
aa4aafb
to
8614660
Compare
Just a thought: conceptually, could this function just be the same as the |
Mmmmm. This is a great point. I think you're right. Would it make sense to group them together, call it |
I thought that could be a possibility. Worth thinking about. The current dihypergraph one only make sense as a bipartite if the edge markers are drawn though, I'd say. Maybe directedness and "bipartite-ness" are two somewhat independent elements here. And then the |
I have refactored the function so that it accepts both directed and undirected hypergraphs. Because of this, |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I have now implemented all of your suggestions, @maximelucas. Should be ready to re-review. |
I'll do that next week! |
Great! Thanks so much! |
Some more minor comments.. we're almost there, it's a lot of code 😄 I'll check the rest of the code later today. |
@maximelucas thanks so much! Let me know when you're done and I'll start addressing your comments! |
I think I checked all of it 😛 |
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
Co-authored-by: Maxime Lucas <maximelucas@users.noreply.github.com>
@maximelucas, thanks for the review! A quick overview of my changes based on your comments:
At this point, I believe that I've addressed all your comments. Let me know if there are other things you would like me to change. |
Looks good, thanks so much for the work! |
This PR does the following:
draw_dihypergraph
and moves its contents todraw_bipartite
.draw_bipartite
now handlesHypergraph
andDiHypergraph
objects.bipartite_spring_layout
position function.