Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xgi data docs page #496

Merged
merged 11 commits into from
Dec 1, 2023
Merged

Xgi data docs page #496

merged 11 commits into from
Dec 1, 2023

Conversation

nwlandry
Copy link
Collaborator

Added a page for XGI-DATA on readthedocs.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81003a7) 92.03% compared to head (28820ae) 92.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          60       60           
  Lines        4369     4369           
=======================================
  Hits         4021     4021           
  Misses        348      348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry marked this pull request as ready for review December 1, 2023 02:55
@maximelucas
Copy link
Collaborator

Looks great, thanks so much. I guess it's better to wait to merge the other PR first to check if the table gets populated correctly.

@maximelucas
Copy link
Collaborator

maximelucas commented Dec 1, 2023

This is not up to date. Did we miss this in the previous PR or will it be updated automatically?

Screenshot 2023-12-01 at 14 49 34

Edit: forget about this, after git pull and pip install -e .\["all"\] all works fine.

@nwlandry
Copy link
Collaborator Author

nwlandry commented Dec 1, 2023

That doesn't match what I get when I call that function from the main branch of xgi or this branch. What branch are you using?

@nwlandry
Copy link
Collaborator Author

nwlandry commented Dec 1, 2023

Looks great, thanks so much. I guess it's better to wait to merge the other PR first to check if the table gets populated correctly.

Yep, I'll address your comments over there first!

@maximelucas
Copy link
Collaborator

That doesn't match what I get when I call that function from the main branch of xgi or this branch. What branch are you using?

You were too fast, you replied faster than I updated my comment after realising I just needed to upgrade :)

@nwlandry nwlandry merged commit 925ebd1 into main Dec 1, 2023
23 checks passed
@nwlandry nwlandry deleted the xgi-data-docs-page branch December 1, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants