Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: format XGI-DATA numbers #532

Merged
merged 1 commit into from
Apr 6, 2024
Merged

feat: format XGI-DATA numbers #532

merged 1 commit into from
Apr 6, 2024

Conversation

doabell
Copy link
Contributor

@doabell doabell commented Apr 5, 2024

Due to an upstream change in XGI-DATA (xgi-org/xgi-data#23), the XGI-DATA page now shows numbers without comma separators.

This PR adds the commas back.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (caf534b) to head (735fe4a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          60       60           
  Lines        4417     4417           
=======================================
  Hits         4071     4071           
  Misses        346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doabell
Copy link
Contributor Author

doabell commented Apr 5, 2024

@nwlandry Would you be able to take a quick look? Thanks!

Preview works properly on:

  • Edge Windows
  • Firefox Windows
  • Safari iOS
  • Firefox Android
  • Chrome Android

Properly changes commas to dots with a de-DE locale on Firefox Windows.

@nwlandry
Copy link
Collaborator

nwlandry commented Apr 6, 2024

Nice work, @doabell! Looks great.

@nwlandry nwlandry merged commit 2d632a1 into xgi-org:main Apr 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants