Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify cleanup functions #569

Merged
merged 6 commits into from
Aug 5, 2024
Merged

simplify cleanup functions #569

merged 6 commits into from
Aug 5, 2024

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Aug 5, 2024

This PR condenses unnecessary code and fixes #568.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (e01ddd5) to head (9744e19).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   92.51%   92.45%   -0.06%     
==========================================
  Files          59       59              
  Lines        4393     4361      -32     
==========================================
- Hits         4064     4032      -32     
  Misses        329      329              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xgi/core/hypergraph.py Outdated Show resolved Hide resolved
@maximelucas
Copy link
Collaborator

Looks good thanks! Just a few questions

@nwlandry
Copy link
Collaborator Author

nwlandry commented Aug 5, 2024

Thanks for the review, @maximelucas! I moved the in-place vs. new network logic to the convert_labels_to_integers function and I think it streamlines things.

@nwlandry nwlandry merged commit 0475563 into main Aug 5, 2024
24 checks passed
@nwlandry nwlandry deleted the clean-up-cleanup branch August 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

homogenise large_connected_hypergraph implementations
2 participants