-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify cleanup functions #569
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
- Coverage 92.51% 92.45% -0.06%
==========================================
Files 59 59
Lines 4393 4361 -32
==========================================
- Hits 4064 4032 -32
Misses 329 329 ☔ View full report in Codecov by Sentry. |
Looks good thanks! Just a few questions |
Thanks for the review, @maximelucas! I moved the in-place vs. new network logic to the |
This PR condenses unnecessary code and fixes #568.