Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castero (0.4.1) does not close correctly if it is playing #26

Closed
node64 opened this issue Feb 16, 2019 · 9 comments
Closed

Castero (0.4.1) does not close correctly if it is playing #26

node64 opened this issue Feb 16, 2019 · 9 comments

Comments

@node64
Copy link

node64 commented Feb 16, 2019

I have to close it with Ctrl+c

@xgi
Copy link
Owner

xgi commented Feb 17, 2019

I have seen this before but I'm not able to reproduce it at the moment. I could try to add more explicit player termination but that should be handled automatically. This does however happen if there are active downloads (from pressing 's') -- was that the case for you?

@node64
Copy link
Author

node64 commented Feb 18, 2019

Sorry for my English
No, the problem does not come from active downloads, the problem has to do with the player (mpv). Castero closes but the player does not, without giving any message or error.
Do not add anything just for me, it's not a big problem :)

xgi added a commit that referenced this issue Feb 19, 2019
@xgi
Copy link
Owner

xgi commented Feb 19, 2019

I haven't been able to reproduce this myself so I can't test it, but could you check if this is resolved with 71ad704?

@node64
Copy link
Author

node64 commented Feb 21, 2019

I'm sorry for the delay
The problem persists, very strange

@node64
Copy link
Author

node64 commented Feb 21, 2019

castero

I made this gif because my English is too bad to describe the problem.
First time castero was opened without reproducing and it is seen that it closes correctly, the second time it is reproducing and it is when it fails.

@xgi
Copy link
Owner

xgi commented Feb 24, 2019

Okay, I was able to reproduce the problem with mpv 0.14.0 (which is supported, I just happened to have a newer version on my system). However it seemed to be resolved for me with the latest commit.

If you didn't before, can you try uninstalling castero with pip uninstall castero (your config/feeds will still be saved) and then doing a Manual Installation.

@node64
Copy link
Author

node64 commented Feb 27, 2019

I uninstall and install as you say and the problem persists. But now I discovered that the error only occurs when mpv is buffering the podcast, when the audio is load all buffer castero closes correctly.

My mpv version is 0.29.1

@node64
Copy link
Author

node64 commented May 27, 2019

@xgi I write to tell you that for me this problem is solved in the latest version.

@xgi xgi closed this as completed May 27, 2019
@duganchen
Copy link

This is definitely happening to me with Castero 0.6.0.

If I press ENTER on a podcast episode to start playing it in mpv, then press "q" to exit the player, then the TUI exits and I can see my shell prompt, but I can't do anything. I need to press CTRL+C to regain access to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants