Stop treating document as an optional #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be expected that a given view / viewcontroller always has a corresponding backing document. If it doesn't, we currently fail silently, which makes debugging more difficult. The EditView also no longer needs to have its own reference to the document. This can instead be exposed via the datasource protocol (which may be poorly named).
This is more in line with Cocoa naming conventions, and makes using Xcode quick-open easier (ViewContainer and ViewController are too similar.)
|
I also added a little commit renaming the EditViewContainer to EditContainerView; the earlier name's similarity to EditViewController made using Xcode's quick-open panel frustrating. |
|
Last I played around with this, it was making the sending of scroll not update its "last" if document was nil. It would only send new scroll parameters if the were different than the "last" ones, so when document was nil it would drop it on the floor. So my only concern is, could there be a race condition where document is nil? If there's a good reason why not, I'm happy to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that had bit me last week when I was playing around with some other drawing changes. By treating the document as an optional we were failing silently if we tried to send an RPC while it was
nil. I think it's better if we crash in that situation.