feat/fix: Allow to opt-out of replacing slashes in keys #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiCO2k any idea how to fix that without introducing a BC? |
|
Alright, the idea I have come up with to not bring a BC is to introduce the option that allows disabling the errorish (in some cases) behavior. Covers my use case of the |
BR0kEN-
changed the title
|
Thanks for the PR, will review it and let you know |
|
@xiCO2k please let me know whether this is something that can be expected or should I forget about it. |
|
Hey @BR0kEN- I think this is probably not the option. I think a better way would be to take a look on both json with the full string and with the other way, do you want to make a PR with that? Thanks again, |
|
Didn't get what you meant. What JSON? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#115