[pull] main from google:main #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
https://swiftshader.googlesource.com/SwiftShader.git/+log/389854967d78..c4dfa69de7de 2024-07-16 swiftshader.regress@gmail.com Regres: Update test lists @ 38985496 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-skia-autoroll Please CC bsalomon@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Test-Debian10-Clang-GCE-GPU-SwiftShader-x86_64-Debug-All-SwiftShader Bug: None Tbr: nicolettep@google.com Change-Id: I97bf3796a5066eb27b2c4ff31004eb24118b9e8c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878356 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/16be0748ef57..50a01de3a8ed 2024-07-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 53ada6b4af6d to 468fcbe033fa (8 revisions) 2024-07-17 zhaoming.jiang@intel.com Dawn: always report valid subgroups limits if adapter supported 2024-07-17 cwallez@chromium.org Make WireTest::instance a wgpu::Instance instead of WGPUInstance. 2024-07-17 gman@chromium.org Remove expected failures from compat expectations 2024-07-16 bsheedy@google.com Update and sync expectation headers 2024-07-16 rharrison@chromium.org [tint][ir][fuzz] Prevent fuzzer from crashing on malformed user calls 2024-07-16 shrekshao@google.com [Compat] Remove Pixel 6 stale end2end test suppressions 2024-07-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from a54abe841e8f to 9f0764b4f988 (1 revision) 2024-07-16 rharrison@chromium.org [tint][ir][fuzz] Prevent fuzzer from crashing on malformed vars 2024-07-16 bajones@chromium.org Validate depthBias isn't used with points/lines 2024-07-16 shrekshao@google.com [Compat] Remove disable depth stencil read toggles 2024-07-16 cwallez@chromium.org [Kotlin]: Use JNIContext for temporary "new/new[]" allocations 2024-07-16 shrekshao@google.com [Compat] Fix clearTexture for cube texture 2024-07-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 389854967d78 to c4dfa69de7de (1 revision) 2024-07-16 cwallez@chromium.org [Kotlin] build.gradle: Only build webgpu_c_bundled. 2024-07-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7dc21774dc62 to 244fbd880c41 (15 revisions) 2024-07-16 chouinard@google.com [Tint] Validate subgroup builtins as input only 2024-07-16 dawn-automated-expectations@chops-service-accounts.iam.gserviceaccount.com Roll third_party/webgpu-cts/ c623e2bf2..20425f60b (1 commit) 2024-07-16 cwallez@chromium.org [Kotlin]: Use RAII types for the temp buffer in Enumerate* 2024-07-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a8eded771305 to 53ada6b4af6d (4 revisions) 2024-07-16 cwallez@chromium.org [Kotlin]: Introduce a JNIContext helper, use it to free JNI allocations 2024-07-16 cwallez@chromium.org generator_lib.py: Add support for importing templates in templates If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: cwallez@google.com Change-Id: I9d9ef4ac1dd72d5b3258ee0e9b422c4f328b38f9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878358 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/736d19678782..298c34c0e789 2024-07-16 sunxiaodi@google.com [pinpoint] support 'avg' as valid request value for statistic 2024-07-16 ashwinpv@google.com Add support to select trace for the plot summary bar. 2024-07-16 ashwinpv@google.com Pass in the dryRunRequests instance to alertsApi 2024-07-16 borenet@google.com [task scheduler] Fix orphaned job queues 2024-07-16 wenbinzhang@google.com [chromeperf] propagate regression id to grouping logic 2024-07-16 jeffyoon@google.com [pinpoint] adding activity options for catapult bisect sub activities 2024-07-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 791894e4c44f to 9b51399218e2 (5 revisions) 2024-07-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from 925d3cac96a5 to 736d19678782 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:340935348 Tbr: kjlubick@google.com Change-Id: Iae8f11ab4dcffb1de3d6a8920ac09751cdd86814 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878159 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/298c34c0e789..35f1db95b279 2024-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from 736d19678782 to 298c34c0e789 (8 revisions) 2024-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Depot Tools from 9b51399218e2 to 88f793b4be43 (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/sk-tool-skia Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: kjlubick@google.com Change-Id: Icc4771aa2d4424d9b7f7744cf114f1cee4234268 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878361 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/2efce9babc18..1f87cbc925fe 2024-07-17 syoussefi@chromium.org Vulkan: Fix late-added resolve attachment tracking 2024-07-16 yuxinhu@google.com Manual roll VK-GL-CTS from 43432bf265e3 to 5b2dfe7c775a (17 revisions) 2024-07-16 lexa.knyazev@gmail.com Fix gl::floatToNormalized for negative inputs 2024-07-16 lexa.knyazev@gmail.com Add ReadPixelsTextureNorm16PBOTest 2024-07-16 geofflang@chromium.org WebGPU: Add pipeline creation and caching. 2024-07-16 cclao@google.com Vulkan: Restrict VkEvent to TBRs 2024-07-16 ynovikov@chromium.org End ANGLE Mac Intel 14.5 experiment 2024-07-16 geofflang@chromium.org GL: Disable GL_KHR_blend_equation_advanced on various devices 2024-07-16 shrekshao@google.com GL: Fix map input buffer out of range in streamAttributes 2024-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7dc21774dc62 to 99f840c7c7ad (13 revisions) 2024-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f23c77132e0b to 389854967d78 (1 revision) 2024-07-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from dcc3741ff616 to 4be473888de4 (519 revisions) 2024-07-16 abdolrashidi@google.com Fix validation regarding cube map array dims 2024-07-15 yuxinhu@google.com Vulkan: remove unused function 2024-07-15 romanl@google.com Add necessary MSAN include when ANGLE_WITH_MSAN 2024-07-15 romanl@google.com dEQP tests: skip comp_swap r32i/r32ui on Pixel 6 2024-07-15 steven@uplinklabs.net vulkan: filter out devices with insufficient API version 2024-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from d3a8a2da6ae3 to dcc3741ff616 (894 revisions) 2024-07-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9563c7bbc6c9 to 7dc21774dc62 (15 revisions) 2024-07-15 romanl@google.com Refactoring: move angle::HashMap and HashSet to own header 2024-07-14 ynovikov@chromium.org Start Win Intel UHD 770 experiment 2024-07-12 cclao@google.com Vulkan: Enable event based image barrier 2024-07-12 imranziad@google.com Vulkan: feature for cached non-coherent for dyn/stream buffers 2024-07-12 lexa.knyazev@gmail.com Metal: Remove link tasks dependency on context 2024-07-12 romanl@google.com Revert "Disallow read color type conversions for norm16 formats" 2024-07-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bc656cdad31e to 9563c7bbc6c9 (11 revisions) 2024-07-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 51ac27c135bf to d3a8a2da6ae3 (571 revisions) 2024-07-11 lexa.knyazev@gmail.com Metal: Remove library creation dependency on ContextDevice 2024-07-11 lexa.knyazev@gmail.com D3D11: Pass 3D slice index to Image11::copyWithoutConversion 2024-07-11 cclao@google.com Vulkan: Exclude compute/preFrag only access images from event 2024-07-11 cclao@google.com Vulkan: Limit VkEvent for images that has fragment access only 2024-07-11 romanl@google.com Avoid including fstream from angleutils.h 2024-07-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5748d73603a8 to 51ac27c135bf (686 revisions) 2024-07-11 romanl@google.com angle_enable_wgpu requires X11 on Linux 2024-07-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 67847f196c19 to bc656cdad31e (7 revisions) 2024-07-11 steven@uplinklabs.net egl: add missing extension string for D3D LUID 2024-07-10 syoussefi@chromium.org Vulkan: Rework swap-time barrier logic 2024-07-10 syoussefi@chromium.org Vulkan: Make surface RP check independent from framebuffer object 2024-07-10 syoussefi@chromium.org Vulkan: Prepare syncval suppressions for dynamic rendering 2024-07-10 lexa.knyazev@gmail.com D3D11: Cleanup stale CopyTexImageTestES3 suppressions 2024-07-10 cclao@google.com Vulkan: Add ImageHelper::onRenderPassAttach helper function 2024-07-10 cclao@google.com Vulkan: Let ContextVk::onResourceAccess uses retainImage 2024-07-10 abdolrashidi@google.com Resolve compilation during program link resolve 2024-07-10 romanl@google.com Revert "Temporarily angle_enable_vulkan_api_dump_layer default false" 2024-07-10 syoussefi@chromium.org Revert "Vulkan: Use VK_KHR_dynamic_rendering[_local_read]" 2024-07-10 romanl@google.com Add a note about std::aligned_alloc caveats 2024-07-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1d4b1061b004 to 67847f196c19 (3 revisions) 2024-07-10 lexa.knyazev@gmail.com Disallow read color type conversions for norm16 formats 2024-07-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f0fb088cc7f4 to 5748d73603a8 (622 revisions) 2024-07-09 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 17d345a0f23d to 1d4b1061b004 (24 revisions) 2024-07-09 i.nazarov@samsung.com Vulkan: Fix EGL_EXT_buffer_age with single buffered surface 2024-07-09 romanl@google.com Move loadimage SSE includes/defines out of common headers 2024-07-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b1148c13c7a9 to f0fb088cc7f4 (639 revisions) 2024-07-09 syoussefi@chromium.org Vulkan: Use VK_KHR_dynamic_rendering[_local_read] 2024-07-08 lexa.knyazev@gmail.com Do not rely on 16-bit color read conversions in tests, Part 2 2024-07-08 cclao@google.com Vulkan: Limit VkEvent for usage matters for Manhattan31 only 2024-07-08 hailinzhang@google.com vulkan: add workround for speical shadowmap at intel device. 2024-07-08 ynovikov@chromium.org Start ANGLE Intel macOS 14.5 experiment 2024-07-08 romanl@google.com Tests: fix MultithreadFenceDraw, MultithreadFenceTexImage 2024-07-08 lexa.knyazev@gmail.com Do not rely on 16-bit color read conversions in tests 2024-07-08 romanl@google.com Temporarily angle_enable_vulkan_api_dump_layer default false 2024-07-08 syoussefi@chromium.org Vulkan: Remove unused render pass closure reason 2024-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 5fdd3da87369 to 17d345a0f23d (10 revisions) 2024-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a98f22a2505a to b1148c13c7a9 (354 revisions) 2024-07-08 syoussefi@chromium.org Vulkan: Fix SPIR-V gen for literally indexed swizzles 2024-07-08 lexa.knyazev@gmail.com Rename 16-bit EXPECT_PIXEL test helpers 2024-07-05 lexa.knyazev@gmail.com D3D11: Use built-in position for gl_FragCoord.z on SM 4.0+ 2024-07-05 ynovikov@chromium.org Roll chromium_revision c174259bf6..a98f22a250 (1323232:1323712) 2024-07-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a0ec371d8331 to f23c77132e0b (1 revision) 2024-07-05 rop@google.com Updating ceval's README.chromium to include Revision 2024-07-05 lexa.knyazev@gmail.com Metal: Remove MTLGetMSL dependency on context 2024-07-05 rop@google.com Updating clspv's README.chromium to include Revision 2024-07-05 syoussefi@chromium.org Add Revision: field to third party 2024-07-04 geofflang@chromium.org GL: Allow shader compilation with cached translated source 2024-07-04 i.nazarov@samsung.com Vulkan: Rename DescriptorSetLayoutDesc update() to addBinding() 2024-07-04 geofflang@chromium.org GL: Simplify members of ShaderGL. 2024-07-04 lexa.knyazev@gmail.com Metal: Disable fast math if isinf or isnan are used 2024-07-04 syoussefi@chromium.org Vulkan: Easier to read SPIR-V disassembly 2024-07-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 34f452e68b67 to c174259bf610 (620 revisions) 2024-07-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 51d79108bbb3 to 34f452e68b67 (970 revisions) 2024-07-03 lexa.knyazev@gmail.com Release all memory allocated in TCompiler::compile 2024-07-03 geofflang@chromium.org Reland: GL: Support KHR_blend_equation_advanced 2024-07-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5faad80a00af to 5fdd3da87369 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,nicolettep@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: nicolettep@google.com Test: Test: angle_end2end_tests --gtest_filter=EGLBufferAgeTest.SingleBuffer* Change-Id: I00bc549d73e787bbb20a1ae44c4cd9a342f1ccaa Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878357 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/472fd6a2d49e..ace59194583a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC nicolettep@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: nicolettep@google.com Change-Id: Ic743ffacafef7d963caf34236e57f60444a5a4cc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878362 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Bug: b/259548724 Change-Id: I658027f5f0c1f450ed973ea69f8b07ab45cd092d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/877338 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
http://review.skia.org/874247 caused the output of SPIRV-Cross to change for one test. This CL updates the golden outputs to match. Bug: b/40045541 Change-Id: I1c3066297cc807c030b270d7c0d1c3a256f00de7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878466 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Kaylee Lubick <kjlubick@google.com>
Previously, building a target like `dm` or `viewer` would build most of the SkSL golden outputs, but would omit HLSL/WGSL. This was just an oversight. Change-Id: Ie2fa09ab0d198b572e942e574d760b57b50949bd Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878617 Commit-Queue: Kaylee Lubick <kjlubick@google.com> Reviewed-by: Kaylee Lubick <kjlubick@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
This GM never draws anything since it only looked in a hard coded location for data. If something like this is ever needed again it can be written as a viewer slide. Change-Id: I7b076fcd889517fd6c7560e259e8fb9d322f8f67 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878619 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Auto-Submit: Ben Wagner <bungeman@google.com>
This allows Xcode to know this file is part of this project when building for iOS. Change-Id: Iff61e491ffadf112796f071d3e24b1abc062cdc8 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878473 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Ben Wagner <bungeman@google.com>
This gm class was oddly defined in the skiagm namespace with the static registration also done in the skiagm namespace. Instead define the class in an anonymous namespace and do the static registration at top level. Change-Id: I78609c44d74d945fbbd28ac8de586c1e5ac9b553 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878620 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Ben Wagner <bungeman@google.com>
This isn't currently defined explicitly. Change-Id: I50ae28064a740701be244119f563301e42855692 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878736 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Ben Wagner <bungeman@google.com>
This not being here was an oversight and led to https://skia-review.googlesource.com/c/skia/+/878466 Change-Id: Ibbbbdd66cba3334c30f781f3a6fed469fdd51e65 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878616 Reviewed-by: John Stiles <johnstiles@google.com>
Strictly a copy & paste with the removal of the unnecessary forward declarations Bug: b/238759480 Change-Id: Ie087cecf067871ccbc44d0e04989cd3500fe0f1f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878618 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
Chromium is rebaselined, so this (less robust) code can be deleted Bug: 336617138 Change-Id: I1a4d6cc18eafaf9a8f0c97bb77f33aba61ade47a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/877676 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
https://skia.googlesource.com/skcms.git/+log/bc467ef5ef35..2395877dc55f 2024-07-17 chengyangyang-hf@loongson.cn Add LSX optimations for loong64. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skcms-skia-autoroll Please CC brianosman@google.com,kjlubick@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Canary-Chromium Tbr: brianosman@google.com,kjlubick@google.com Change-Id: Icafa33678ee764613fdf01943df3bf664ab67bb0 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/878658 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Change-Id: Ic5ce9658348fedbc4ca70ad52154d4de870db8b4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/877677 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )