Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in documentation of gstrs #141

Merged
merged 1 commit into from
May 30, 2024

Conversation

maxaehle
Copy link
Contributor

The documentation of dgscon gives conflicting information about how its input arguments L and U have to be computed:

  • In the main text, it refers to a function DGETRF which, to my knowledge, does not exist in SuperLU.
  • In the description of the arguments, it refers to dgstrf.

The proposed change replaces DGETRF by DGSTRF in the comments in the code. It seems that the html documentation are also part of the repo, and would therefore need to be rebuilt.

As a side question, I was wondering if it is possible to use dgscon with an incomplete LU decomposition formed by dgsitrf?

I'm interested because I'm currently trying to extend the SciPy wrapper for SuperLU in response to scipy/scipy#18969.

@xiaoyeli xiaoyeli merged commit 4cc2cdb into xiaoyeli:master May 30, 2024
@xiaoyeli
Copy link
Owner

Thanks. I'll update doxygen document separately.
Regarding your question with ILU: condition estimation needs accurate LU decomposition. ILU would not be useful for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants