-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can someone share me a screenshot of Arabic(or any RTL language) browser ui interface ,like chrome or firefox? #1632
Comments
The left/right relationship of forward/backward is unchanged, but the position of the forward/backward combo is moved to another side of the topbar. https://addons.mozilla.org/firefox/addon/العربية-language-pack/ |
goldendict-ng/src/ui/mainwindow.cc Lines 880 to 884 in 2053511
then I think this piece of code can be removed. |
Actually, no. I checked it again, the backward is on the right side after switching to Arabic language (but they look the same. I said, "left/right relationship of forward/backward is unchanged" because they still look like Change |
In the current GD, this piece of code won't be triggered on Linux in anyway. The whole app level layout direction is never set. No idea what the "auto" means (using goldendict-ng/src/ui/mainwindow.cc Lines 880 to 884 in 2053511
Unrelated, but force setting RTL via |
the above code will make the button appear as -> <- .(If worked.) If layout is concerned,all the buttons should be rearranged (through layout direction etc, or toolbar->layout->direction). Based on above ,the code is still nonsense. |
The code is needed when it triggers because buttons will be added from right to left if the whole app is RTL layout as shown in the forced layout screenshot #1632 (comment) . Don't remove it. However, I don't find a way to trigger the whole application RTL layout.
On Linux, the layout doesn't change to RTL (which is what browsers do) like Qt's doc says. |
got your idea |
Can someone share me a screenshot of Arabic(or any RTL language) browser ui interface ,like chrome or firefox?
I want to check the layout of Forward/Back button in the browser.
The text was updated successfully, but these errors were encountered: